Issue 565049: Windows: Put ScopedHGlobal in the right scope so it unlocks a STGMEDIUM's han...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 565049: Windows: Put ScopedHGlobal in the right scope so it unlocks a STGMEDIUM's han... (Closed)

Created:
10 years, 10 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Windows: Put ScopedHGlobal in the right scope so it unlocks a STGMEDIUM's handle before we call ReleaseStgMedium. BUG=34528 TEST=Wine + Valgrind bot goes green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38075

Patch Set 1 #

Patch Set 2 : fix compile #

Total comments: 1

Patch Set 3 : fix nit #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -48 lines)			Patch
	M	app/clipboard/clipboard_util_win.cc	View	1 2	7 chunks	+65 lines, -48 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

I'm not the biggest win32 expert, but it seems like a good idea not to ...

10 years, 10 months ago (2010-02-04 02:00:38 UTC) #1

Peter Kasting

10 years, 10 months ago (2010-02-04 02:18:45 UTC) #2

LGTM

P.S. I didn't write this code and haven't the foggiest idea what most of it is
doing, I just agree with your assessment that the existing code looks risky.

http://codereview.chromium.org/565049/diff/2001/2002
File app/clipboard/clipboard_util_win.cc (right):

http://codereview.chromium.org/565049/diff/2001/2002#newcode1
app/clipboard/clipboard_util_win.cc:1: // Copyright (c) 2009 The Chromium
Authors. All rights reserved.
Nit: 2010

Expand Messages | Collapse Messages