Windows: Put ScopedHGlobal in the right scope so it unlocks a STGMEDIUM's han...

app/clipboard/clipboard_util_win.cc

-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/clipboard/clipboard_util_win.h"
 
 #include <shellapi.h>
 #include <shlwapi.h>
 #include <wininet.h>
 
 #include "base/basictypes.h"
@@ skipping 174 matching lines @@
   if (!HasUrl(data_object))
     return false;
 
   // Try to extract a URL from |data_object| in a variety of formats.
   STGMEDIUM store;
   if (GetUrlFromHDrop(data_object, url, title))
     return true;
 
   if (SUCCEEDED(data_object->GetData(GetMozUrlFormat(), &store)) ||
       SUCCEEDED(data_object->GetData(GetUrlWFormat(), &store))) {
-    // Mozilla URL format or unicode URL
-    ScopedHGlobal<wchar_t> data(store.hGlobal);
-    SplitUrlAndTitle(data.get(), url, title);
+    {
+      // Mozilla URL format or unicode URL
+      ScopedHGlobal<wchar_t> data(store.hGlobal);
+      SplitUrlAndTitle(data.get(), url, title);
+    }
     ReleaseStgMedium(&store);
     return true;
   }
 
   if (SUCCEEDED(data_object->GetData(GetUrlFormat(), &store))) {
-    // URL using ascii
-    ScopedHGlobal<char> data(store.hGlobal);
-    SplitUrlAndTitle(UTF8ToWide(data.get()), url, title);
+    {
+      // URL using ascii
+      ScopedHGlobal<char> data(store.hGlobal);
+      SplitUrlAndTitle(UTF8ToWide(data.get()), url, title);
+    }
     ReleaseStgMedium(&store);
     return true;
   }
 
   if (SUCCEEDED(data_object->GetData(GetFilenameWFormat(), &store))) {
-    // filename using unicode
-    ScopedHGlobal<wchar_t> data(store.hGlobal);
     bool success = false;
-    if (data.get() && data.get()[0] &&
-        (PathFileExists(data.get()) || PathIsUNC(data.get()))) {
-      wchar_t file_url[INTERNET_MAX_URL_LENGTH];
-      DWORD file_url_len = arraysize(file_url);
-      if (SUCCEEDED(::UrlCreateFromPathW(data.get(), file_url, &file_url_len,
-                                         0))) {
-        url->assign(file_url);
-        title->assign(file_url);
-        success = true;
+    {
+      // filename using unicode
+      ScopedHGlobal<wchar_t> data(store.hGlobal);
+      if (data.get() && data.get()[0] &&
+          (PathFileExists(data.get()) || PathIsUNC(data.get()))) {
+        wchar_t file_url[INTERNET_MAX_URL_LENGTH];
+        DWORD file_url_len = arraysize(file_url);
+        if (SUCCEEDED(::UrlCreateFromPathW(data.get(), file_url, &file_url_len,
+                                           0))) {
+          url->assign(file_url);
+          title->assign(file_url);
+          success = true;
+        }
       }
     }
     ReleaseStgMedium(&store);
     if (success)
       return true;
   }
 
   if (SUCCEEDED(data_object->GetData(GetFilenameFormat(), &store))) {
-    // filename using ascii
-    ScopedHGlobal<char> data(store.hGlobal);
     bool success = false;
-    if (data.get() && data.get()[0] && (PathFileExistsA(data.get()) ||
-                                        PathIsUNCA(data.get()))) {
-      char file_url[INTERNET_MAX_URL_LENGTH];
-      DWORD file_url_len = arraysize(file_url);
-      if (SUCCEEDED(::UrlCreateFromPathA(data.get(), file_url, &file_url_len,
-                                         0))) {
-        url->assign(UTF8ToWide(file_url));
-        title->assign(*url);
-        success = true;
+    {
+      // filename using ascii
+      ScopedHGlobal<char> data(store.hGlobal);
+      if (data.get() && data.get()[0] && (PathFileExistsA(data.get()) ||
+                                          PathIsUNCA(data.get()))) {
+        char file_url[INTERNET_MAX_URL_LENGTH];
+        DWORD file_url_len = arraysize(file_url);
+        if (SUCCEEDED(::UrlCreateFromPathA(data.get(), file_url, &file_url_len,
+                                           0))) {
+          url->assign(UTF8ToWide(file_url));
+          title->assign(*url);
+          success = true;
+        }
       }
     }
     ReleaseStgMedium(&store);
     if (success)
       return true;
   }
 
   return false;
 }
 
@@ skipping 28 matching lines @@
 }
 
 bool ClipboardUtil::GetPlainText(IDataObject* data_object,
                                  std::wstring* plain_text) {
   DCHECK(data_object && plain_text);
   if (!HasPlainText(data_object))
     return false;
 
   STGMEDIUM store;
   if (SUCCEEDED(data_object->GetData(GetPlainTextWFormat(), &store))) {
-    // Unicode text
-    ScopedHGlobal<wchar_t> data(store.hGlobal);
-    plain_text->assign(data.get());
+    {
+      // Unicode text
+      ScopedHGlobal<wchar_t> data(store.hGlobal);
+      plain_text->assign(data.get());
+    }
     ReleaseStgMedium(&store);
     return true;
   }
 
   if (SUCCEEDED(data_object->GetData(GetPlainTextFormat(), &store))) {
-    // ascii text
-    ScopedHGlobal<char> data(store.hGlobal);
-    plain_text->assign(UTF8ToWide(data.get()));
+    {
+      // ascii text
+      ScopedHGlobal<char> data(store.hGlobal);
+      plain_text->assign(UTF8ToWide(data.get()));
+    }
     ReleaseStgMedium(&store);
     return true;
   }
 
   // If a file is dropped on the window, it does not provide either of the
   // plain text formats, so here we try to forcibly get a url.
   std::wstring title;
   return GetUrl(data_object, plain_text, &title);
 }
 
 bool ClipboardUtil::GetHtml(IDataObject* data_object,
                             std::wstring* html, std::string* base_url) {
   DCHECK(data_object && html && base_url);
 
   STGMEDIUM store;
   if (SUCCEEDED(data_object->QueryGetData(GetHtmlFormat())) &&
       SUCCEEDED(data_object->GetData(GetHtmlFormat(), &store))) {
-    // MS CF html
-    ScopedHGlobal<char> data(store.hGlobal);
+    {
+      // MS CF html
+      ScopedHGlobal<char> data(store.hGlobal);
 
-    std::string html_utf8;
-    CFHtmlToHtml(std::string(data.get(), data.Size()), &html_utf8, base_url);
-    html->assign(UTF8ToWide(html_utf8));
-
+      std::string html_utf8;
+      CFHtmlToHtml(std::string(data.get(), data.Size()), &html_utf8, base_url);
+      html->assign(UTF8ToWide(html_utf8));
+    }
     ReleaseStgMedium(&store);
     return true;
   }
 
   if (FAILED(data_object->QueryGetData(GetTextHtmlFormat())))
     return false;
 
   if (FAILED(data_object->GetData(GetTextHtmlFormat(), &store)))
     return false;
 
-  // text/html
-  ScopedHGlobal<wchar_t> data(store.hGlobal);
-  html->assign(data.get());
+  {
+    // text/html
+    ScopedHGlobal<wchar_t> data(store.hGlobal);
+    html->assign(data.get());
+  }
   ReleaseStgMedium(&store);
   return true;
 }
 
 bool ClipboardUtil::GetFileContents(IDataObject* data_object,
     std::wstring* filename, std::string* file_contents) {
   DCHECK(data_object && filename && file_contents);
   if (!SUCCEEDED(data_object->QueryGetData(GetFileContentFormatZero())) &&
       !SUCCEEDED(data_object->QueryGetData(GetFileDescriptorFormat())))
     return false;
 
   STGMEDIUM content;
   // The call to GetData can be very slow depending on what is in
   // |data_object|.
   if (SUCCEEDED(data_object->GetData(GetFileContentFormatZero(), &content))) {
     if (TYMED_HGLOBAL == content.tymed) {
       ScopedHGlobal<char> data(content.hGlobal);
       file_contents->assign(data.get(), data.Size());
     }
     ReleaseStgMedium(&content);
   }
 
   STGMEDIUM description;
   if (SUCCEEDED(data_object->GetData(GetFileDescriptorFormat(),
                                      &description))) {
-    ScopedHGlobal<FILEGROUPDESCRIPTOR> fgd(description.hGlobal);
-    // We expect there to be at least one file in here.
-    DCHECK_GE(fgd->cItems, 1u);
-    filename->assign(fgd->fgd[0].cFileName);
+    {
+      ScopedHGlobal<FILEGROUPDESCRIPTOR> fgd(description.hGlobal);
+      // We expect there to be at least one file in here.
+      DCHECK_GE(fgd->cItems, 1u);
+      filename->assign(fgd->fgd[0].cFileName);
+    }
     ReleaseStgMedium(&description);
   }
   return true;
 }
 
 // HtmlToCFHtml and CFHtmlToHtml are based on similar methods in
 // WebCore/platform/win/ClipboardUtilitiesWin.cpp.
 /*
  * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
  *
@@ skipping 100 matching lines @@
     size_t fragment_start = cf_html.find('>', tag_start) + 1;
     size_t tag_end = cf_html.rfind("EndFragment", std::string::npos);
     size_t fragment_end = cf_html.rfind('<', tag_end);
     if (fragment_start != std::string::npos &&
         fragment_end != std::string::npos) {
       *html = cf_html.substr(fragment_start, fragment_end - fragment_start);
       TrimWhitespace(*html, TRIM_ALL, html);
     }
   }
 }