Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: webkit/glue/plugins/webplugin_impl.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/plugins/plugin_stream_url.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/plugins/webplugin_impl.h
diff --git a/webkit/glue/plugins/webplugin_impl.h b/webkit/glue/plugins/webplugin_impl.h
index 4f3b6c70ee6f54f034328feb20b419ad162b2004..d319df15ed5ac42f20bcccec1477f5b45c73fd44 100644
--- a/webkit/glue/plugins/webplugin_impl.h
+++ b/webkit/glue/plugins/webplugin_impl.h
@@ -104,11 +104,11 @@ class WebPluginImpl : public WebPlugin,
virtual void stopFind();
// WebPlugin implementation:
- void SetWindow(gfx::PluginWindowHandle window);
+ virtual void SetWindow(gfx::PluginWindowHandle window);
virtual void SetAcceptsInputEvents(bool accepts) {
accepts_input_events_ = accepts;
}
- void WillDestroyWindow(gfx::PluginWindowHandle window);
+ virtual void WillDestroyWindow(gfx::PluginWindowHandle window);
#if defined(OS_WIN)
void SetWindowlessPumpEvent(HANDLE pump_messages_event) { }
#endif
@@ -220,24 +220,24 @@ class WebPluginImpl : public WebPlugin,
// request given a handle.
void RemoveClient(WebKit::WebURLLoader* loader);
- void HandleURLRequest(const char* url,
- const char *method,
- const char* target,
- const char* buf,
- unsigned int len,
- int notify_id,
- bool popups_allowed,
- bool notify_redirects);
+ virtual void HandleURLRequest(const char* url,
+ const char *method,
+ const char* target,
+ const char* buf,
+ unsigned int len,
+ int notify_id,
+ bool popups_allowed,
+ bool notify_redirects);
- void CancelDocumentLoad();
+ virtual void CancelDocumentLoad();
- void InitiateHTTPRangeRequest(
+ virtual void InitiateHTTPRangeRequest(
const char* url, const char* range_info, int pending_request_id);
- void SetDeferResourceLoading(unsigned long resource_id, bool defer);
+ virtual void SetDeferResourceLoading(unsigned long resource_id, bool defer);
// Ignore in-process plugins mode for this flag.
- bool IsOffTheRecord() { return false; }
+ virtual bool IsOffTheRecord() { return false; }
// Handles HTTP multipart responses, i.e. responses received with a HTTP
// status code of 206.
« no previous file with comments | « webkit/glue/plugins/plugin_stream_url.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698