Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1561)

Unified Diff: base/values.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_loop_proxy_impl.h ('k') | base/waitable_event_watcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/values.h
diff --git a/base/values.h b/base/values.h
index f020405b6a17c45cdb3aa41c9df26059cd4768c0..68b8f0038fcb2cf4371e5d17abfc6cb94c24d671 100644
--- a/base/values.h
+++ b/base/values.h
@@ -124,7 +124,7 @@ class FundamentalValue : public Value {
explicit FundamentalValue(bool in_value);
explicit FundamentalValue(int in_value);
explicit FundamentalValue(double in_value);
- ~FundamentalValue();
+ virtual ~FundamentalValue();
// Subclassed methods
virtual bool GetAsBoolean(bool* out_value) const;
@@ -151,12 +151,12 @@ class StringValue : public Value {
// Initializes a StringValue with a string16.
explicit StringValue(const string16& in_value);
- ~StringValue();
+ virtual ~StringValue();
// Subclassed methods
- bool GetAsString(std::string* out_value) const;
- bool GetAsString(string16* out_value) const;
- Value* DeepCopy() const;
+ virtual bool GetAsString(std::string* out_value) const;
+ virtual bool GetAsString(string16* out_value) const;
+ virtual Value* DeepCopy() const;
virtual bool Equals(const Value* other) const;
private:
@@ -178,10 +178,10 @@ class BinaryValue: public Value {
// Returns NULL if buffer is NULL.
static BinaryValue* CreateWithCopiedBuffer(const char* buffer, size_t size);
- ~BinaryValue();
+ virtual ~BinaryValue();
// Subclassed methods
- Value* DeepCopy() const;
+ virtual Value* DeepCopy() const;
virtual bool Equals(const Value* other) const;
size_t GetSize() const { return size_; }
@@ -205,10 +205,10 @@ class BinaryValue: public Value {
class DictionaryValue : public Value {
public:
DictionaryValue();
- ~DictionaryValue();
+ virtual ~DictionaryValue();
// Subclassed methods
- Value* DeepCopy() const;
+ virtual Value* DeepCopy() const;
virtual bool Equals(const Value* other) const;
// Returns true if the current dictionary has a value for the given key.
@@ -368,7 +368,7 @@ class ListValue : public Value {
// Subclassed methods
virtual bool GetAsList(ListValue** out_value);
- Value* DeepCopy() const;
+ virtual Value* DeepCopy() const;
virtual bool Equals(const Value* other) const;
// Clears the contents of this ListValue
« no previous file with comments | « base/message_loop_proxy_impl.h ('k') | base/waitable_event_watcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698