Issue 5644: Add platform_canvas_unittest.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5644: Add platform_canvas_unittest.cc (Closed)

Created:
12 years, 2 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
brettw, awalker, Amanda Walker

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add platform_canvas_unittest.cc Also fixes issue 2977. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2777

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -39 lines)			Patch
M	base/base.xcodeproj/project.pbxproj	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	base/gfx/bitmap_platform_device_mac.cc	View	3 chunks	+8 lines, -5 lines	1 comment	Download
M	base/gfx/platform_canvas_unittest.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	base/gfx/platform_device_mac.cc	View	2 chunks	+24 lines, -32 lines	0 comments	Download
M	base/gfx/skia_utils_mac.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	base/gfx/skia_utils_mac.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jeremy

Missing pieces to get platform_canvas_unittests.cc up and running.

12 years, 2 months ago (2008-10-01 21:11:31 UTC) #1

Amanda Walker

LGTM. Good job on the transformation matrix stuff. http://codereview.chromium.org/5644/diff/1/2 File base/gfx/bitmap_platform_device_mac.cc (right): http://codereview.chromium.org/5644/diff/1/2#newcode155 Line 155: ...

12 years, 2 months ago (2008-10-01 21:32:01 UTC) #3

lgtmtoo

Expand Messages | Collapse Messages