Add platform_canvas_unittest.cc

base/gfx/bitmap_platform_device_mac.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <time.h>
 
 #include "SkMatrix.h"
 #include "SkRegion.h"
 #include "SkUtils.h"
 
@@ skipping 112 matching lines @@
 }
 
 void BitmapPlatformDeviceMac::BitmapPlatformDeviceMacData::LoadConfig() {
   if (!config_dirty_ || !bitmap_context_)
     return;  // Nothing to do.
   config_dirty_ = false;
 
   // Transform.
   SkMatrix t(transform_);
   LoadTransformToCGContext(bitmap_context_, t);
-  
   t.setTranslateX(-t.getTranslateX());
   t.setTranslateY(-t.getTranslateY());
   LoadClippingRegionToCGContext(bitmap_context_, clip_region_, t);
 }
 
 
 // We use this static factory function instead of the regular constructor so
 // that we can create the pixel data before calling the constructor. This is
 // required so that we can call the base class' constructor with the pixel
 // data.
 BitmapPlatformDeviceMac* BitmapPlatformDeviceMac::Create(CGContextRef context,
                                                          int width,
                                                          int height,
                                                          bool is_opaque) {
-  // TODO(playmobil): remove debug code.
-  //printf("BitmapPlatformDeviceMac::Create(%d,%d)\n", width, height);
-  // each pixel is 4 bytes (RGBA):
   void* data = malloc(height * width * 4);
   if (!data) return NULL;
 
   SkBitmap bitmap;
   bitmap.setConfig(SkBitmap::kARGB_8888_Config, width, height);
   bitmap.setPixels(data);
+  
+  // Note: The Windows implementation clears the Bitmap later on.
+  // This bares mentioning since removal of this line makes the

[Amanda Walker, 2008/10/01 21:32:01]

"bares" should be "bears" :-)

+  // unit tests only fail periodically (or when MallocPreScribble is set).
+  bitmap.eraseARGB(0, 0, 0, 0);
+  
   bitmap.setIsOpaque(is_opaque);
 
   if (is_opaque) {
 #ifndef NDEBUG
     // To aid in finding bugs, we set the background color to something
     // obviously wrong so it will be noticable when it is not cleared
     bitmap.eraseARGB(255, 0, 255, 128);  // bright bluish green
 #endif
   }
   
   CGColorSpaceRef color_space =
     CGColorSpaceCreateWithName(kCGColorSpaceGenericRGB);
   // allocate a bitmap context with 4 components per pixel (RGBA):
   CGContextRef bitmap_context =
     CGBitmapContextCreate(data, width, height, 8, width*4,
                           color_space, kCGImageAlphaPremultipliedLast);
-  // change the coordinate system to match WebCore's
+  
+  // Change the coordinate system to match WebCore's
   CGContextTranslateCTM(bitmap_context, 0, height);
   CGContextScaleCTM(bitmap_context, 1.0, -1.0);
   CGColorSpaceRelease(color_space);
 
   // The device object will take ownership of the graphics context.
   return new BitmapPlatformDeviceMac(
       new BitmapPlatformDeviceMacData(bitmap_context), bitmap);
 }
 
 // The device will own the bitmap, which corresponds to also owning the pixel
@@ skipping 93 matching lines @@
       size_t offset = (i + bitmap_start_y) * row_words + bitmap_start_x;
       for (int j = 0; j < width; j++) {
         adjustor(data + offset + j);
       }
     }
   }
 }
 
 }  // namespace gfx