Index: chrome/common/extensions/extension.h |
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h |
index b9ec910046a724bdb2ff5a654044551b0c43f7c1..a09e254ac6c1fc635f4a5345c4ed2b06b0069723 100644 |
--- a/chrome/common/extensions/extension.h |
+++ b/chrome/common/extensions/extension.h |
@@ -123,13 +123,19 @@ class Extension : public base::RefCountedThreadSafe<Extension> { |
// should display at install time. |
std::vector<string16> GetPermissionMessages() const; |
- // Returns the distinct hosts that should be displayed in the install UI. This |
- // discards some of the detail that is present in the manifest to make it as |
- // easy as possible to process by users. In particular we disregard the scheme |
- // and path components of URLPatterns and de-dupe the result. |
+ // Returns the distinct hosts that can be displayed in the install UI or be |
+ // used for privilege comparisons. This discards some of the detail that is |
+ // present in the manifest to make it as easy as possible to process by users. |
+ // In particular we disregard the scheme and path components of URLPatterns |
+ // and de-dupe the result. |
Erik does not do reviews
2010/12/03 17:56:42
...the result, including based on filtering out co
jstritar
2010/12/03 21:52:55
Done.
|
+ // NOTE: If using the hosts for privilege comparisons, |include_rcd| must be |
Erik does not do reviews
2010/12/03 17:56:42
Rather than explaining it as a NOTE like this, I'd
jstritar
2010/12/03 21:52:55
Done.
|
+ // set to false so that the RCDs are stripped off. This ensures that |
+ // equivalent |host_patterns| reliably return the same distinct hosts, |
+ // regardless of the pattern order or presence of additional domains with |
+ // the same host but other RCDs. |
static std::vector<std::string> GetDistinctHosts( |
- const URLPatternList& host_patterns); |
- std::vector<std::string> GetDistinctHosts() const; |
+ const URLPatternList& host_patterns, bool include_rcd); |
+ std::vector<std::string> GetDistinctHosts(bool include_rcd) const; |
// Icon sizes used by the extension system. |
static const int kIconSizes[]; |