Fix issue that causes some extensions to be disabled right after installation.

chrome/common/extensions/extension.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 #define CHROME_COMMON_EXTENSIONS_EXTENSION_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 105 matching lines @@
   // Return the update url used by gallery/webstore extensions.
   static GURL GalleryUpdateUrl(bool secure);
 
   // The install message id for |permission|.  Returns 0 if none exists.
   static int GetPermissionMessageId(const std::string& permission);
 
   // Returns the full list of permission messages that this extension
   // should display at install time.
   std::vector<string16> GetPermissionMessages() const;
 
-  // Returns the distinct hosts that should be displayed in the install UI. This
-  // discards some of the detail that is present in the manifest to make it as
-  // easy as possible to process by users. In particular we disregard the scheme
-  // and path components of URLPatterns and de-dupe the result.
+  // Returns the distinct hosts that can be displayed in the install UI or be
+  // used for privilege comparisons. This discards some of the detail that is
+  // present in the manifest to make it as easy as possible to process by users.
+  // In particular we disregard the scheme and path components of URLPatterns
+  // and de-dupe the result.

[Erik does not do reviews, 2010/12/03 17:56:42]

...the result, including based on filtering out common hosts with differing
RCDs.

[jstritar, 2010/12/03 21:52:55]

Done.

+  // NOTE: If using the hosts for privilege comparisons, |include_rcd| must be

[Erik does not do reviews, 2010/12/03 17:56:42]

Rather than explaining it as a NOTE like this, I'd just explain the parameter's
two use cases:
If |include_rcd| is true, then the de-duped result will be the first full entry,
including its RCD.  So if the list was *.google.co.uk and *.google.com, the
returned value would just be *.google.co.uk.  Keeping the RCD in the result is
useful for display purposes when you want to show the user one sample hostname
from the list.  If you need to compare two URLPatternLists for security
equality, then set |include_rcd| to false, which will return a result like
"*.google.", regardless of the order of the hosts.

[jstritar, 2010/12/03 21:52:55]

Done.

+  // set to false so that the RCDs are stripped off. This ensures that
+  // equivalent |host_patterns| reliably return the same distinct hosts,
+  // regardless of the pattern order or presence of additional domains with
+  // the same host but other RCDs.
   static std::vector<std::string> GetDistinctHosts(
-      const URLPatternList& host_patterns);
-  std::vector<std::string> GetDistinctHosts() const;
+      const URLPatternList& host_patterns, bool include_rcd);
+  std::vector<std::string> GetDistinctHosts(bool include_rcd) const;
 
   // Icon sizes used by the extension system.
   static const int kIconSizes[];
 
   // Max size (both dimensions) for browser and page actions.
   static const int kPageActionIconMaxSize;
   static const int kBrowserActionIconMaxSize;
 
   // Each permission is a module that the extension is permitted to use.
   //
@@ skipping 562 matching lines @@
   std::set<std::string> extension_api_permissions;
   // TODO(akalin): Once we have a unified ExtensionType, replace the
   // below member variables with a member of that type.
   bool is_theme;
   bool is_app;
   bool converted_from_user_script;
   GURL update_url;
 };
 
 #endif  // CHROME_COMMON_EXTENSIONS_EXTENSION_H_