Issue 5628: Fixes bug where JSON reader errored on reading vertical tabs (\v). The...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5628: Fixes bug where JSON reader errored on reading vertical tabs (\v). The... (Closed)

Created:
12 years, 2 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
tony, tc

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes bug where JSON reader errored on reading vertical tabs (\v). The writer properly escapes a vertical tab, but the readed instead errored on the vertical this. This resulted in lost bookmarks:( BUG=3031 TEST=covered by unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2759

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -2 lines)			Patch
M	base/json_reader.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	base/json_reader_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/string_escape.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.  Sorry about that :(

Expand Messages | Collapse Messages