Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2946)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/json_reader_unittest.cc

Issue 5628: Fixes bug where JSON reader errored on reading vertical tabs (\v). The... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/json_reader.cc ('k') | base/string_escape.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/json_reader_unittest.cc
===================================================================
--- base/json_reader_unittest.cc (revision 2755)
+++ base/json_reader_unittest.cc (working copy)
@@ -214,13 +214,13 @@
// Test basic string escapes
root = NULL;
- ASSERT_TRUE(JSONReader::JsonToValue("\" \\\"\\\\\\/\\b\\f\\n\\r\\t\"", &root,
+ ASSERT_TRUE(JSONReader::JsonToValue("\" \\\"\\\\\\/\\b\\f\\n\\r\\t\\v\"", &root,
false, false));
ASSERT_TRUE(root);
ASSERT_TRUE(root->IsType(Value::TYPE_STRING));
str_val.clear();
ASSERT_TRUE(root->GetAsString(&str_val));
- ASSERT_EQ(L" \"\\/\b\f\n\r\t", str_val);
+ ASSERT_EQ(L" \"\\/\b\f\n\r\t\v", str_val);
delete root;
// Test hex and unicode escapes including the null character.
« no previous file with comments | « base/json_reader.cc ('k') | base/string_escape.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698