Issue 5626004: Update valid URLPattern schemes in ExtensionPrefs::GetGrantedPermissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5626004: Update valid URLPattern schemes in ExtensionPrefs::GetGrantedPermissions (Closed)

Created:
10 years ago by jstritar

Modified:
9 years, 6 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Erik does not do reviews, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Update valid URLPattern schemes in ExtensionPrefs::GetGrantedPermissions. Adds SCHEME_CHROMEUI as a valid URLPattern scheme in GetGrantedPermissions. Ensures these schemes stay in sync with those in Extension. BUG=65309 TEST=ExtensionPrefsGrantedPermissions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68439

Patch Set 1 #

Patch Set 2 : remove kValidWebExtentSchemes from GetGrantedPermissions #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -4 lines)			Patch
M	chrome/browser/extensions/extension_prefs.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_prefs_unittest.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension.cc	View		2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jstritar

This is a little update to the URL pattern validation in ExtensionPrefs::GetGrantedPermissions.

10 years ago (2010-12-03 18:02:38 UTC) #1

jstritar

I uploaded a new CL that removes the kValidWebExtentScheme from GetGrantedPermissions and adds a comment ...

10 years ago (2010-12-03 21:56:29 UTC) #2

lgtm

Expand Messages | Collapse Messages