chrome/browser/extensions/extension_prefs_unittest.cc - Issue 5626004: Update valid URLPattern schemes in ExtensionPrefs::GetGrantedPermissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_prefs_unittest.cc

Issue 5626004: Update valid URLPattern schemes in ExtensionPrefs::GetGrantedPermissions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove kValidWebExtentSchemes from GetGrantedPermissions Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_prefs_unittest.cc

diff --git a/chrome/browser/extensions/extension_prefs_unittest.cc b/chrome/browser/extensions/extension_prefs_unittest.cc

index 84b2224b16406b780978a046f50f6243c7f00ada..d6dcc232a888be99d0e1743c4e81111987606139 100644

--- a/chrome/browser/extensions/extension_prefs_unittest.cc

+++ b/chrome/browser/extensions/extension_prefs_unittest.cc

@@ -182,6 +182,7 @@ class ExtensionPrefsGrantedPermissions : public ExtensionPrefsTest {

AddPattern(&host_perm_set1_, "http://*.google.com/*");

AddPattern(&host_perm_set1_, "http://example.com/*");

+ AddPattern(&host_perm_set1_, "chrome://favicon/*");

AddPattern(&host_perm_set2_, "https://*.google.com/*");

// with duplicate:

@@ -193,6 +194,7 @@ class ExtensionPrefsGrantedPermissions : public ExtensionPrefsTest {

AddPattern(&host_permissions_, "http://*.google.com/*");

AddPattern(&host_permissions_, "http://example.com/*");

+ AddPattern(&host_permissions_, "chrome://favicon/*");

AddPattern(&host_permissions_, "https://*.google.com/*");

std::set<std::string> empty_set;

« no previous file with comments | « chrome/browser/extensions/extension_prefs.cc ('k') | chrome/common/extensions/extension.h » ('j') | no next file with comments »