Move more code from headers to implementation.

remoting/protocol/rtp_utils.h

Index: remoting/protocol/rtp_utils.h
diff --git a/remoting/protocol/rtp_utils.h b/remoting/protocol/rtp_utils.h
index 599ffaf51121071c2aa456e51bb3b172b2094d96..4441d78eb6b0610564678d6e6029f4f6f25f9eac 100644
--- a/remoting/protocol/rtp_utils.h
+++ b/remoting/protocol/rtp_utils.h
@@ -11,16 +11,7 @@ namespace remoting {
 namespace protocol {
 
 struct RtpHeader {
-  RtpHeader()
-      : padding(false),
-        extension(false),
-        sources(0),
-        marker(false),
-        payload_type(0),
-        sequence_number(0),
-        timestamp(0),
-        sync_source_id(0) {
-  }
+  RtpHeader();

[Sergey Ulanov, 2010/12/07 21:15:42]

This was inlined intentionally. This file is included only in several files, and
this constructor is used only in two places. It shouldn't affect compilation
performance in any significant way. Can we please keep it as it is?

[Elliot Glaysher, 2010/12/07 21:49:25]

This was found by an automated process which is going to be deployed on the
waterfall Real Soon Now. I don't believe that this will make a difference either
way at runtime.

[Sergey Ulanov, 2010/12/07 22:00:38]

Yes, it doesn't make much difference in performance in this particular case, but
IMHO it is more readable with inlined constructor.
With the new automated process, will it be possible to inline constructors when
it is necessary for performance reasons?

 
   // RTP version is always set to 2.
   // version = 2
@@ -36,16 +27,7 @@ struct RtpHeader {
 };
 
 struct RtcpReceiverReport {
-  RtcpReceiverReport()
-      : receiver_ssrc(0),
-        sender_ssrc(0),
-        loss_fraction(0),
-        total_lost_packets(0),
-        last_sequence_number(0),
-        jitter(0),
-        last_sender_report_timestamp(0),
-        last_sender_report_delay(0) {
-  }
+  RtcpReceiverReport();

[Sergey Ulanov, 2010/12/07 21:15:42]

same here.

 
   uint32 receiver_ssrc;
   uint32 sender_ssrc;