Move more code from headers to implementation.

remoting/protocol/rtp_utils.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_RTP_UTILS_H_
 #define REMOTING_PROTOCOL_RTP_UTILS_H_
 
 #include "base/basictypes.h"
 
 namespace remoting {
 namespace protocol {
 
 struct RtpHeader {
-  RtpHeader()
-      : padding(false),
-        extension(false),
-        sources(0),
-        marker(false),
-        payload_type(0),
-        sequence_number(0),
-        timestamp(0),
-        sync_source_id(0) {
-  }
+  RtpHeader();

[Sergey Ulanov, 2010/12/07 21:15:42]

This was inlined intentionally. This file is included only in several files, and
this constructor is used only in two places. It shouldn't affect compilation
performance in any significant way. Can we please keep it as it is?

[Elliot Glaysher, 2010/12/07 21:49:25]

This was found by an automated process which is going to be deployed on the
waterfall Real Soon Now. I don't believe that this will make a difference either
way at runtime.

[Sergey Ulanov, 2010/12/07 22:00:38]

Yes, it doesn't make much difference in performance in this particular case, but
IMHO it is more readable with inlined constructor.
With the new automated process, will it be possible to inline constructors when
it is necessary for performance reasons?

 
   // RTP version is always set to 2.
   // version = 2
   bool padding;
   bool extension;
   uint8 sources;
   bool marker;
   uint8 payload_type;
   uint16 sequence_number;
   uint32 timestamp;
   uint32 sync_source_id;
   uint32 source_id[15];
 };
 
 struct RtcpReceiverReport {
-  RtcpReceiverReport()
-      : receiver_ssrc(0),
-        sender_ssrc(0),
-        loss_fraction(0),
-        total_lost_packets(0),
-        last_sequence_number(0),
-        jitter(0),
-        last_sender_report_timestamp(0),
-        last_sender_report_delay(0) {
-  }
+  RtcpReceiverReport();

[Sergey Ulanov, 2010/12/07 21:15:42]

same here.

 
   uint32 receiver_ssrc;
   uint32 sender_ssrc;
   uint8 loss_fraction;  // 8bit fixed point value in the interval [0..1].
   uint32 total_lost_packets;
   uint32 last_sequence_number;
   uint32 jitter;
   uint32 last_sender_report_timestamp;
   uint32 last_sender_report_delay;
 };
@@ skipping 67 matching lines @@
 
 // Unpacks VP8 Payload Descriptor. If the descriptor is not valid
 // returns -1, otherwise returns size of the descriptor.
 int UnpackVp8Descriptor(const uint8* buffer, int buffer_size,
                         Vp8Descriptor* descriptor);
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_RTP_UTILS_H_