Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 56172: Clean up return statements in the code generator by explicitly... (Closed)

Created:
11 years, 8 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Clean up return statements in the code generator by explicitly counting the reference to the return value and passing it to the return label. This requires threading it through try/catch and try/finally. The return value is loaded into eax more lazily than before. Also, perform some related refactoring of jump targets. Committed: http://code.google.com/p/v8/source/detail?r=1669

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -128 lines) Patch
M src/codegen.h View 1 chunk +32 lines, -28 lines 0 comments Download
M src/codegen.cc View 1 chunk +12 lines, -1 line 0 comments Download
M src/codegen-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/codegen-ia32.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M src/codegen-ia32.cc View 1 6 chunks +75 lines, -62 lines 0 comments Download
M src/jump-target.h View 5 chunks +12 lines, -3 lines 0 comments Download
M src/jump-target.cc View 14 chunks +94 lines, -23 lines 0 comments Download
M src/jump-target-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/jump-target-ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
11 years, 8 months ago (2009-04-02 08:10:16 UTC) #1
Kevin Millikin (Chromium)
Fixed typos.
11 years, 8 months ago (2009-04-02 08:13:31 UTC) #2
Kasper Lund
11 years, 8 months ago (2009-04-02 08:19:08 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698