Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: src/codegen.cc

Issue 56172: Clean up return statements in the code generator by explicitly... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/codegen.h ('k') | src/codegen-arm.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 548 matching lines...) Expand 10 before | Expand all | Expand 10 after
559 if (FLAG_debug_info) { 559 if (FLAG_debug_info) {
560 int pos = fun->start_position(); 560 int pos = fun->start_position();
561 if (pos != RelocInfo::kNoPosition) { 561 if (pos != RelocInfo::kNoPosition) {
562 masm()->RecordStatementPosition(pos); 562 masm()->RecordStatementPosition(pos);
563 masm()->RecordPosition(pos); 563 masm()->RecordPosition(pos);
564 } 564 }
565 } 565 }
566 } 566 }
567 567
568 568
569 void CodeGenerator::CodeForReturnPosition(FunctionLiteral* fun) {
570 if (FLAG_debug_info) {
571 int pos = fun->start_position();
572 if (pos != RelocInfo::kNoPosition) {
573 masm()->RecordStatementPosition(pos);
574 masm()->RecordPosition(pos);
575 }
576 }
577 }
578
579
569 void CodeGenerator::CodeForStatementPosition(Node* node) { 580 void CodeGenerator::CodeForStatementPosition(Node* node) {
570 if (FLAG_debug_info) { 581 if (FLAG_debug_info) {
571 int pos = node->statement_pos(); 582 int pos = node->statement_pos();
572 if (pos != RelocInfo::kNoPosition) { 583 if (pos != RelocInfo::kNoPosition) {
573 masm()->RecordStatementPosition(pos); 584 masm()->RecordStatementPosition(pos);
574 CodeForSourcePosition(pos); 585 masm()->RecordPosition(pos);
575 } 586 }
576 } 587 }
577 } 588 }
578 589
579 590
580 void CodeGenerator::CodeForSourcePosition(int pos) { 591 void CodeGenerator::CodeForSourcePosition(int pos) {
581 if (FLAG_debug_info) { 592 if (FLAG_debug_info) {
582 if (pos != RelocInfo::kNoPosition) { 593 if (pos != RelocInfo::kNoPosition) {
583 masm()->RecordPosition(pos); 594 masm()->RecordPosition(pos);
584 } 595 }
(...skipping 14 matching lines...) Expand all
599 void ArgumentsAccessStub::Generate(MacroAssembler* masm) { 610 void ArgumentsAccessStub::Generate(MacroAssembler* masm) {
600 switch (type_) { 611 switch (type_) {
601 case READ_LENGTH: GenerateReadLength(masm); break; 612 case READ_LENGTH: GenerateReadLength(masm); break;
602 case READ_ELEMENT: GenerateReadElement(masm); break; 613 case READ_ELEMENT: GenerateReadElement(masm); break;
603 case NEW_OBJECT: GenerateNewObject(masm); break; 614 case NEW_OBJECT: GenerateNewObject(masm); break;
604 } 615 }
605 } 616 }
606 617
607 618
608 } } // namespace v8::internal 619 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/codegen.h ('k') | src/codegen-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698