Use LanguageCodeWithDialects instead of LanguageCode to get 'zh-CN' ...

Use LanguageCodeWithDialects instead of LanguageCode to get 'zh-CN' 
instead of 'zh'. 

This was a part of http://codereview.chromium.org/549123/show (LGTM'd by jcampan by email), but that CL is failing the unittest after the CLD update by jcampan. So, 
I'm landing this small change first.

BUG=32759
TEST=NONE
TBR=jcampan


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38073

[jcampan, 2010-02-04 01:28:15]

LGTM

Jay

On Wed, Feb 3, 2010 at 5:21 PM,  <jshin@chromium.org> wrote:
> Reviewers: jcampan,
>
> Description:
> Use LanguageCodeWithDialects instead of LanguageCode to get 'zh-CN'
> instead of 'zh'.
>
> This was a part of http://codereview.chromium.org/549123/show (LGTM'd by
> jcampan
> by email), but that CL is failing the unittest after the CLD update by
> jcampan.
> So,
> I'm landing this small change first.
>
> BUG=32759
> TEST=NONE
> TBR=jcampan
>
>
> Please review this at http://codereview.chromium.org/561065
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/renderer/render_view.cc
>
>
> Index: chrome/renderer/render_view.cc
> ===================================================================
> --- chrome/renderer/render_view.cc      (revision 38030)
> +++ chrome/renderer/render_view.cc      (working copy)
> @@ -3170,9 +3170,11 @@
>       cld_language != TG_UNKNOWN_LANGUAGE) {
>     // We should not use LanguageCode_ISO_639_1 because it does not cover
> all
>     // the languages CLD can detect. As a result, it'll return the invalid
> -    // language code for tradtional Chinese among others. |LanguageCode|
> will go
> -    // through ISO 639-1, ISO-639-2 and 'other' tables to do the 'right'
> thing.
> -    language = LanguageCode(cld_language);
> +    // language code for tradtional Chinese among others.
> +    // |LanguageCodeWithDialect| will go through ISO 639-1, ISO-639-2 and
> +    // 'other' tables to do the 'right' thing. In addition, it'll return
> zh-CN
> +    // for Simplified Chinese.
> +    language = LanguageCodeWithDialects(cld_language);
>   }
>   return language;
>  }
> @@ -4277,4 +4279,3 @@
>   Send(new ViewHostMsg_GPUPluginBuffersSwapped(routing_id(), window));
>  }
>  #endif
> -
>
>
>