Issue 561012: Change the GLES2Implementation Flush and Finish functions...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 561012: Change the GLES2Implementation Flush and Finish functions... (Closed)

Created:
10 years, 10 months ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Change the GLES2Implementation Flush and Finish functions to emluate the GLES2 glFlush and glFinish more correctly. I don't like the fact that the GLES2CmdHelper::Finish autogeneated from glFinish overrides CommandBufferHelper::Finish but I'm not sure I'm feeling like making all those functions start with gl or something and all the fixes required just to avoid that. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37863

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -7 lines)			Patch
	M	gpu/command_buffer/client/gles2_implementation.cc	View		2 chunks	+15 lines, -4 lines	0 comments	Download
	M	gpu/command_buffer/client/gles2_implementation_autogen.h	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages