Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 56060: Add just enough state changes from EXTERNAL (outside V8) to OTHER... (Closed)

Created:
11 years, 8 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add just enough state changes from EXTERNAL (outside V8) to OTHER (generic state inside V8) in the API to allow the V8 shell to run all the mjsunit tests with heap protection on. These state changes are only taken when built with ENABLE_HEAP_PROTECTION. The two states OTHER and EXTERNAL are treated the same because we will not properly reenter OTHER through the API. Committed: http://code.google.com/p/v8/source/detail?r=1643

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -14 lines) Patch
M src/api.cc View 9 chunks +14 lines, -0 lines 0 comments Download
M src/global-handles.cc View 1 chunk +5 lines, -1 line 1 comment Download
M src/handles.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +16 lines, -12 lines 0 comments Download
M src/log.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
If this seems OK, the next change will be to put ENTER_V8 everywhere in the ...
11 years, 8 months ago (2009-03-30 13:12:53 UTC) #1
Mads Ager (chromium)
11 years, 8 months ago (2009-03-30 13:26:06 UTC) #2
LGTM

I don't like having the macro all over the api implementation, but I don't see
how else to do this.

http://codereview.chromium.org/56060/diff/1/6
File src/global-handles.cc (right):

http://codereview.chromium.org/56060/diff/1/6#newcode157
Line 157: { // Leaving V8.
This probably does not lint?

Powered by Google App Engine
This is Rietveld 408576698