src/global-handles.cc - Issue 56060: Add just enough state changes from EXTERNAL (outside V8) to OTHER...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/global-handles.cc

Issue 56060: Add just enough state changes from EXTERNAL (outside V8) to OTHER... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/global-handles.cc

===================================================================

--- src/global-handles.cc (revision 1641)

+++ src/global-handles.cc (working copy)

@@ -153,7 +153,11 @@

// behavior.

WeakReferenceCallback func = callback();

if (func != NULL) {

- func(v8::Persistent<v8::Object>(ToApi<v8::Object>(handle())), par);

+ v8::Persistent<v8::Object> object = ToApi<v8::Object>(handle());

+ { // Leaving V8.

Mads Ager (chromium) 2009/03/30 13:26:06 This probably does not lint?

+ VMState state(EXTERNAL);

+ func(object, par);

+ }

}

« no previous file with comments | « src/api.cc ('k') | src/handles.cc » ('j') | no next file with comments »