Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 5601003: Localize instant string. (Closed)

Created:
10 years ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Localize instant string. BUG=58763 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68398

Patch Set 1 #

Patch Set 2 : translateable=false #

Total comments: 1

Patch Set 3 : gurl #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/options/browser_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/instant_confirm_dialog_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/options/general_page_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/instant/instant_confirm_dialog.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/instant/instant_confirm_dialog.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/instant_confirm_window_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/preferences_window_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/instant_confirm_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/options/general_page_view.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
I didn't want to have to add l10n_util and generated_resources to every file that needs ...
10 years ago (2010-12-03 02:56:49 UTC) #1
sky
This looks good, but can we make it return a GURL now rather than a ...
10 years ago (2010-12-03 16:18:28 UTC) #2
Evan Stade
done
10 years ago (2010-12-03 20:39:06 UTC) #3
sky
10 years ago (2010-12-03 20:49:29 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698