Issue 5594009: Adds first cut implementation of a private key store abstraction for openssl

Issue 5594009: Adds first cut implementation of a private key store abstraction for openssl (Closed)

Created:
10 years ago by joth

Modified:
9 years, 7 months ago

Reviewers:
bulach

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, wtc, Ryan Sleevi

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Adds first cut implementation of a private key store abstraction for openssl - this allows keygen created keys to be stored in a platform specific way, and looked up in client auth - still needs additional work in CertDatabase to fully implement client auth BUG=64917 TEST=Keygen unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68836

Patch Set 1 #

Patch Set 2 : ; #

Total comments: 10

Patch Set 3 : bulach comments #

Patch Set 4 : wtc comment from http://codereview.chromium.org/5592003/ #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -14 lines)			Patch
M	net/base/cert_database_openssl.cc	View	1 2 3	4 chunks	+16 lines, -4 lines	0 comments	Download
M	net/base/keygen_handler_openssl.cc	View		2 chunks	+3 lines, -5 lines	0 comments	Download
A	net/base/openssl_memory_private_key_store.cc	View	1 2	1 chunk	+64 lines, -0 lines	0 comments	Download
A	net/base/openssl_private_key_store.h	View	1 2	1 chunk	+51 lines, -0 lines	0 comments	Download
M	net/base/ssl_config_service.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	net/net.gyp	View	1 2 3	2 chunks	+4 lines, -0 lines	0 comments	Download
M	net/socket/ssl_client_socket_openssl.cc	View	1 2 3	2 chunks	+13 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bulach

LGTM rant: I wished the EVP_PKEY* Fetch(EVP_PKEY*) would have different types, but there's nothing we ...

10 years ago (2010-12-08 20:37:00 UTC) #2

joth

10 years ago (2010-12-09 11:20:21 UTC) #3

Thanks for the review.

http://codereview.chromium.org/5594009/diff/2001/net/base/cert_database_opens...
File net/base/cert_database_openssl.cc (right):

http://codereview.chromium.org/5594009/diff/2001/net/base/cert_database_opens...
net/base/cert_database_openssl.cc:11: #include
"net/base/openssl_private_key_store.h"
On 2010/12/08 20:37:00, bulach wrote:
> one up

Done.

http://codereview.chromium.org/5594009/diff/2001/net/base/openssl_memory_priv...
File net/base/openssl_memory_private_key_store.cc (right):

http://codereview.chromium.org/5594009/diff/2001/net/base/openssl_memory_priv...
net/base/openssl_memory_private_key_store.cc:23: ~OpenSSLMemoryKeyStore() {
On 2010/12/08 20:37:00, bulach wrote:
> virtual?

Done.

http://codereview.chromium.org/5594009/diff/2001/net/base/openssl_memory_priv...
net/base/openssl_memory_private_key_store.cc:29: }
On 2010/12/08 20:37:00, bulach wrote:
> \n

Done.

http://codereview.chromium.org/5594009/diff/2001/net/base/openssl_memory_priv...
net/base/openssl_memory_private_key_store.cc:35: }
On 2010/12/08 20:37:00, bulach wrote:
> \n

Done.

http://codereview.chromium.org/5594009/diff/2001/net/base/openssl_private_key...
File net/base/openssl_private_key_store.h (right):

http://codereview.chromium.org/5594009/diff/2001/net/base/openssl_private_key...
net/base/openssl_private_key_store.h:20: // The contract is that the private key
from will be stored in an
On 2010/12/08 20:37:00, bulach wrote:
> s/from//

Done.

Expand Messages | Collapse Messages