Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: net/base/keygen_handler_openssl.cc

Issue 5594009: Adds first cut implementation of a private key store abstraction for openssl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: wtc comment from http://codereview.chromium.org/5592003/ Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/cert_database_openssl.cc ('k') | net/base/openssl_memory_private_key_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/keygen_handler_openssl.cc
diff --git a/net/base/keygen_handler_openssl.cc b/net/base/keygen_handler_openssl.cc
index b04f098b8e9e0a12782477bc08f37bc6e31328da..73aabd75dbaf13fd69baa84fb0e949508f6467fe 100644
--- a/net/base/keygen_handler_openssl.cc
+++ b/net/base/keygen_handler_openssl.cc
@@ -10,6 +10,7 @@
#include "base/logging.h"
#include "base/openssl_util.h"
#include "base/scoped_ptr.h"
+#include "net/base/openssl_private_key_store.h"
namespace net {
@@ -18,11 +19,8 @@ std::string KeygenHandler::GenKeyAndSignChallenge() {
base::RSAPrivateKey::Create(key_size_in_bits_));
EVP_PKEY* pkey = key->key();
- if (stores_key_) {
- // TODO(joth): Add an abstraction for persisting OpenSSL private keys.
- // See http://crbug.com/64917
- NOTIMPLEMENTED();
- }
+ if (stores_key_)
+ OpenSSLPrivateKeyStore::GetInstance()->StorePrivateKey(url_, pkey);
base::ScopedOpenSSL<NETSCAPE_SPKI, NETSCAPE_SPKI_free> spki(
NETSCAPE_SPKI_new());
« no previous file with comments | « net/base/cert_database_openssl.cc ('k') | net/base/openssl_memory_private_key_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698