Chromium Code Reviews

Issue 558062: Using options.email for svn credential is not a good idea. (Closed)

Created:
10 years, 10 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Mohamed Mansour
CC:
chromium-reviews
Visibility:
Public.

Description

Using options.email for svn credential is not a good idea. It breaks the use case when a dev outside corp wants to send a job's email to someone else.

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+0 lines, -2 lines)
M trychange.py View 1 chunk +0 lines, -2 lines 0 comments

Messages

Total messages: 2 (0 generated)
M-A Ruel
10 years, 10 months ago (2010-01-30 19:32:09 UTC) #1
Mohamed Mansour
10 years, 10 months ago (2010-01-30 19:33:20 UTC) #2
lgtm!

Powered by Google App Engine