trychange.py - Issue 558062: Using options.email for svn credential is not a good idea.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trychange.py

Issue 558062: Using options.email for svn credential is not a good idea. (Closed)

Patch Set: Created 10 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trychange.py

diff --git a/trychange.py b/trychange.py

index edf1dfdf9a849ce0291fc463f0581af4791e5cf8..71ceb20066769fdc954488bca81e592780b5af38 100755

--- a/trychange.py

+++ b/trychange.py

@@ -334,8 +334,6 @@ def _SendChangeSVN(options):

try:

command = ['svn', 'checkout', '--depth', 'empty', '-q',

options.svn_repo, temp_dir]

- if options.email:

- command.extend(['--username', options.email])

gclient_utils.CheckCall(command)

# TODO(maruel): Use a subdirectory per user?

« no previous file with comments | « no previous file | no next file » | no next file with comments »