Renamed ParseError -> Error, parse_error -> error, kParseNoError -> kNoError,...

Renamed ParseError -> Error, parse_error -> error, kParseNoError -> kNoError, commandBufferEntries -> commandBufferSize.
Added NPDevice3DContextError enumeration.
TEST=none
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37751

[apatrick_chromium, 2010-01-30 01:07:49]

It's not as bad as it looks!

[alokp, 2010-01-30 05:24:06]

lgtm

http://codereview.chromium.org/558054/diff/1/23
File gpu/command_buffer/common/constants.h (right):

http://codereview.chromium.org/558054/diff/1/23#newcode16
gpu/command_buffer/common/constants.h:16: namespace error {
do you really need this error namespace. Atleast one error in error::Error seems
superfluous. I think one gpu namespace is sufficient.

http://codereview.chromium.org/558054/diff/1/8
File gpu/command_buffer/service/gles2_cmd_validation_autogen.h (right):

http://codereview.chromium.org/558054/diff/1/8#newcode12
gpu/command_buffer/service/gles2_cmd_validation_autogen.h:12: bool
ValidateGLenumReadPixelFormat(GLenum value);
this file contains unrelated change. do you want to include this in this cl or
submit separately?

http://codereview.chromium.org/558054/diff/1/9
File gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h
(right):

http://codereview.chromium.org/558054/diff/1/9#newcode37
gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h:37:
bool ValidateGLenumReadPixelFormat(GLenum value) {
unrelated change

[apatrick_chromium, 2010-02-01 22:02:21]

http://codereview.chromium.org/558054/diff/1/23
File gpu/command_buffer/common/constants.h (right):

http://codereview.chromium.org/558054/diff/1/23#newcode16
gpu/command_buffer/common/constants.h:16: namespace error {
Yeah error::Error is annoying. The reason is to get the enum values in a
namespace like error::kInvalidSize.

http://codereview.chromium.org/558054/diff/1/8
File gpu/command_buffer/service/gles2_cmd_validation_autogen.h (right):

http://codereview.chromium.org/558054/diff/1/8#newcode12
gpu/command_buffer/service/gles2_cmd_validation_autogen.h:12: bool
ValidateGLenumReadPixelFormat(GLenum value);
It's because I reran the python script that automatically generates this file
and others. It's seems to put these functions in a different order each time.
gman fixed the script so it sorts them so this won't happen again. The fix is in
this CL.

http://codereview.chromium.org/558054/diff/1/9
File gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h
(right):

http://codereview.chromium.org/558054/diff/1/9#newcode37
gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h:37:
bool ValidateGLenumReadPixelFormat(GLenum value) {
On 2010/01/30 05:24:07, alokp wrote:
> unrelated change

See other comment.

[alokp, 2010-02-01 22:14:28]

lgtm

http://codereview.chromium.org/558054/diff/1/23
File gpu/command_buffer/common/constants.h (right):

http://codereview.chromium.org/558054/diff/1/23#newcode16
gpu/command_buffer/common/constants.h:16: namespace error {
In that case I would rename the enums as following:
kErrorNone,
kErrorInvalidSize,
kErrorXXXX,
kErrorGeneric,

Not a big deal though.