Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 558041: RFC: Try to be much more careful with where we skip the write barrier by:... (Closed)

Created:
10 years, 10 months ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

RFC: Try to be much more careful with where we skip the write barrier by: 1. Avoid using SKIP_WRITE_BARRIER when we don't have to (smis). 2. Check and document the remaining uses of SKIP_WRITE_BARRIER. 3. Only allow GetWriteBarrierMode when in an AssertNoAllocation scope. The only functional change should be in DeepCopyBoilerplate where we no longer use the write barrier mode (because of allocations). I'm running benchmarks to see if this has a measurable impact on performance. Committed: http://code.google.com/p/v8/source/detail?r=3743

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -109 lines) Patch
M src/builtins.cc View 5 chunks +9 lines, -5 lines 0 comments Download
M src/dateparser.cc View 3 chunks +8 lines, -24 lines 0 comments Download
M src/globals.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap.cc View 7 chunks +11 lines, -4 lines 0 comments Download
M src/objects.h View 2 chunks +10 lines, -2 lines 0 comments Download
M src/objects.cc View 25 chunks +37 lines, -38 lines 0 comments Download
M src/objects-inl.h View 4 chunks +10 lines, -6 lines 0 comments Download
M src/runtime.cc View 12 chunks +33 lines, -30 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
10 years, 10 months ago (2010-01-29 09:44:25 UTC) #1
Mads Ager (chromium)
10 years, 10 months ago (2010-01-29 10:13:58 UTC) #2
This looks great!  Please commit if the boilerplate copying change is not a
performance issue. :)

Powered by Google App Engine
This is Rietveld 408576698