Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: src/dateparser.cc

Issue 558041: RFC: Try to be much more careful with where we skip the write barrier by:... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins.cc ('k') | src/globals.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/dateparser.cc
===================================================================
--- src/dateparser.cc (revision 3737)
+++ src/dateparser.cc (working copy)
@@ -72,15 +72,9 @@
if (!Smi::IsValid(year) || !IsMonth(month) || !IsDay(day)) return false;
- output->set(YEAR,
- Smi::FromInt(year),
- SKIP_WRITE_BARRIER);
- output->set(MONTH,
- Smi::FromInt(month - 1),
- SKIP_WRITE_BARRIER); // 0-based
- output->set(DAY,
- Smi::FromInt(day),
- SKIP_WRITE_BARRIER);
+ output->set(YEAR, Smi::FromInt(year));
+ output->set(MONTH, Smi::FromInt(month - 1)); // 0-based
+ output->set(DAY, Smi::FromInt(day));
return true;
}
@@ -103,15 +97,9 @@
if (!IsHour(hour) || !IsMinute(minute) || !IsSecond(second)) return false;
- output->set(HOUR,
- Smi::FromInt(hour),
- SKIP_WRITE_BARRIER);
- output->set(MINUTE,
- Smi::FromInt(minute),
- SKIP_WRITE_BARRIER);
- output->set(SECOND,
- Smi::FromInt(second),
- SKIP_WRITE_BARRIER);
+ output->set(HOUR, Smi::FromInt(hour));
+ output->set(MINUTE, Smi::FromInt(minute));
+ output->set(SECOND, Smi::FromInt(second));
return true;
}
@@ -121,13 +109,9 @@
if (minute_ == kNone) minute_ = 0;
int total_seconds = sign_ * (hour_ * 3600 + minute_ * 60);
if (!Smi::IsValid(total_seconds)) return false;
- output->set(UTC_OFFSET,
- Smi::FromInt(total_seconds),
- SKIP_WRITE_BARRIER);
+ output->set(UTC_OFFSET, Smi::FromInt(total_seconds));
} else {
- output->set(UTC_OFFSET,
- Heap::null_value(),
- SKIP_WRITE_BARRIER);
+ output->set_null(UTC_OFFSET);
}
return true;
}
« no previous file with comments | « src/builtins.cc ('k') | src/globals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698