Exclude text controls from exposing the press action. Structure PerformActio...

chrome/browser/accessibility/browser_accessibility_cocoa.mm

Index: chrome/browser/accessibility/browser_accessibility_cocoa.mm
===================================================================
--- chrome/browser/accessibility/browser_accessibility_cocoa.mm	(revision 68193)
+++ chrome/browser/accessibility/browser_accessibility_cocoa.mm	(working copy)
@@ -300,8 +300,11 @@
   [ret addObject:NSAccessibilityShowMenuAction];
 
   // TODO(dtseng): this should only get set when there's a default action.
-  if ([self role] != NSAccessibilityStaticTextRole)
+  if ([self role] != NSAccessibilityStaticTextRole ||
+      [self role] != NSAccessibilityTextAreaRole ||
+      [self role] != NSAccessibilityTextFieldRole) {
     [ret addObject:NSAccessibilityPressAction];
+  }
 
   return ret;
 }
@@ -410,7 +413,11 @@
 // that backs this object.
 - (void)accessibilityPerformAction:(NSString*)action {
   // TODO(feldstein): Support more actions.
-  [delegate_ doDefaultAction:browserAccessibility_->renderer_id()];
+  if ([action isEqualToString:NSAccessibilityPressAction])

[Chris Guillory, 2010/12/06 19:46:46]

Include braces for this if statement since you are using them below on the else
if.

+    [delegate_ doDefaultAction:browserAccessibility_->renderer_id()];
+  else if ([action isEqualToString:NSAccessibilityShowMenuAction]) {
+    // TODO(dtseng): implement.
+  }
 }
 
 // Returns the description of the given action.