Exclude text controls from exposing the press action. Structure PerformActio...

chrome/browser/accessibility/browser_accessibility_cocoa.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <execinfo.h>
 
 #import "chrome/browser/accessibility/browser_accessibility_cocoa.h"
 
 #include "app/l10n_util_mac.h"
 #include "base/string16.h"
@@ skipping 282 matching lines @@
 }
 
 // Returns an array of action names that this object will respond to.
 - (NSArray*)accessibilityActionNames {
   NSMutableArray* ret = [[[NSMutableArray alloc] init] autorelease];
 
   // General actions.
   [ret addObject:NSAccessibilityShowMenuAction];
 
   // TODO(dtseng): this should only get set when there's a default action.
-  if ([self role] != NSAccessibilityStaticTextRole)
+  if ([self role] != NSAccessibilityStaticTextRole ||
+      [self role] != NSAccessibilityTextAreaRole ||
+      [self role] != NSAccessibilityTextFieldRole) {
     [ret addObject:NSAccessibilityPressAction];
+  }
 
   return ret;
 }
 
 // Returns a sub-array of values for the given attribute value, starting at
 // index, with up to maxCount items.  If the given index is out of bounds,
 // or there are no values for the given attribute, it will return nil.
 // This method is used for querying subsets of values, without having to
 // return a large set of data, such as elements with a large number of
 // children.
@@ skipping 88 matching lines @@
 // Returns whether or not this object should be ignored in the accessibilty
 // tree.
 - (BOOL)accessibilityIsIgnored {
   return [self isIgnored];
 }
 
 // Performs the given accessibilty action on the webkit accessibility object
 // that backs this object.
 - (void)accessibilityPerformAction:(NSString*)action {
   // TODO(feldstein): Support more actions.
-  [delegate_ doDefaultAction:browserAccessibility_->renderer_id()];
+  if ([action isEqualToString:NSAccessibilityPressAction])

[Chris Guillory, 2010/12/06 19:46:46]

Include braces for this if statement since you are using them below on the else
if.

+    [delegate_ doDefaultAction:browserAccessibility_->renderer_id()];
+  else if ([action isEqualToString:NSAccessibilityShowMenuAction]) {
+    // TODO(dtseng): implement.
+  }
 }
 
 // Returns the description of the given action.
 - (NSString*)accessibilityActionDescription:(NSString*)action {
   return NSAccessibilityActionDescription(action);
 }
 
 // Sets an override value for a specific accessibility attribute.
 // This class does not support this.
 - (BOOL)accessibilitySetOverrideValue:(id)value
@@ skipping 42 matching lines @@
 
 - (NSUInteger)hash {
   // Potentially called during dealloc.
   if (!browserAccessibility_)
     return [super hash];
   return browserAccessibility_->renderer_id();
 }
 
 @end