Issue 5579004: Exclude text controls from exposing the press action. Structure PerformActio...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5579004: Exclude text controls from exposing the press action. Structure PerformActio... (Closed)

Created:
10 years ago by David Tseng

Modified:
9 years, 5 months ago

Reviewers:
Chris Guillory, dmazzoni

CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Exclude text controls from exposing the press action. Structure PerformAction properly. BUG=none. TEST=manually with VoiceOver. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68393

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	chrome/browser/accessibility/browser_accessibility_cocoa.mm	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Chris Guillory

10 years ago (2010-12-06 19:46:46 UTC) #2

LGTM. One comment. Add the bug number to the description if one is available.

http://codereview.chromium.org/5579004/diff/1/chrome/browser/accessibility/br...
File chrome/browser/accessibility/browser_accessibility_cocoa.mm (right):

http://codereview.chromium.org/5579004/diff/1/chrome/browser/accessibility/br...
chrome/browser/accessibility/browser_accessibility_cocoa.mm:416: if ([action
isEqualToString:NSAccessibilityPressAction])
Include braces for this if statement since you are using them below on the else
if.

Expand Messages | Collapse Messages