Add a preference to clear plugin data on browser shutdown.

Add a preference to clear plugin data on browser shutdown.

BUG=58235
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69315

[Bernhard Bauer, 2010-12-09 13:56:34]

...aaand another one :-) Please review.

Mattias: FYI.

[Mattias Nissler (ping if slow), 2010-12-09 15:08:54]

Just a minor request for a clarifying comment.

http://codereview.chromium.org/5579002/diff/22001/chrome/browser/plugin_data_...
File chrome/browser/plugin_data_remover_helper.cc (right):

http://codereview.chromium.org/5579002/diff/22001/chrome/browser/plugin_data_...
chrome/browser/plugin_data_remover_helper.cc:15: class
PluginDataRemoverHelper::Internal
Could use a class comment saying that it's RefCountedThreadSafe so it can
outlive the remover object?

[Bernhard Bauer, 2010-12-09 15:20:38]

On Thu, Dec 9, 2010 at 16:08,  <mnissler@chromium.org> wrote:
> Just a minor request for a clarifying comment.
>
>
>
http://codereview.chromium.org/5579002/diff/22001/chrome/browser/plugin_data_...
> File chrome/browser/plugin_data_remover_helper.cc (right):
>
>
http://codereview.chromium.org/5579002/diff/22001/chrome/browser/plugin_data_...
> chrome/browser/plugin_data_remover_helper.cc:15: class
> PluginDataRemoverHelper::Internal
> Could use a class comment saying that it's RefCountedThreadSafe so it
> can outlive the remover object?

Done.

> http://codereview.chromium.org/5579002/
>

[jam, 2010-12-09 17:15:15]

I'm confused, does this supercede http://codereview.chromium.org/5278001/?

On Thu, Dec 9, 2010 at 7:20 AM, Bernhard Bauer <bauerb@chromium.org> wrote:

> On Thu, Dec 9, 2010 at 16:08,  <mnissler@chromium.org> wrote:
> > Just a minor request for a clarifying comment.
> >
> >
> >
>
http://codereview.chromium.org/5579002/diff/22001/chrome/browser/plugin_data_...
> > File chrome/browser/plugin_data_remover_helper.cc (right):
> >
> >
>
http://codereview.chromium.org/5579002/diff/22001/chrome/browser/plugin_data_...
> > chrome/browser/plugin_data_remover_helper.cc:15: class
> > PluginDataRemoverHelper::Internal
> > Could use a class comment saying that it's RefCountedThreadSafe so it
> > can outlive the remover object?
>
> Done.
>
> > http://codereview.chromium.org/5579002/
> >
>

[jam, 2010-12-09 17:17:37]

I'm confused, does this supercede http://codereview.chromium.org/5278001/?

On Thu, Dec 9, 2010 at 7:20 AM, Bernhard Bauer <bauerb@chromium.org> wrote:

> On Thu, Dec 9, 2010 at 16:08,  <mnissler@chromium.org> wrote:
> > Just a minor request for a clarifying comment.
> >
> >
> >
>
http://codereview.chromium.org/5579002/diff/22001/chrome/browser/plugin_data_...
> > File chrome/browser/plugin_data_remover_helper.cc (right):
> >
> >
>
http://codereview.chromium.org/5579002/diff/22001/chrome/browser/plugin_data_...
> > chrome/browser/plugin_data_remover_helper.cc:15: class
> > PluginDataRemoverHelper::Internal
> > Could use a class comment saying that it's RefCountedThreadSafe so it
> > can outlive the remover object?
>
> Done.
>
> > http://codereview.chromium.org/5579002/
> >
>

[Bernhard Bauer, 2010-12-10 16:03:25]

No, http://codereview.chromium.org/5278001 is for the Clear Browsing
Data dialog, this one is for clearing at shutdown. I moved it out of
the original CL after it became clear that clearing data at shutdown
is trickier.

On Thu, Dec 9, 2010 at 18:14, John Abd-El-Malek <jam@chromium.org> wrote:
> I'm confused, does this supercede http://codereview.chromium.org/5278001/?
>
> On Thu, Dec 9, 2010 at 7:20 AM, Bernhard Bauer <bauerb@chromium.org> wrote:
>>
>> On Thu, Dec 9, 2010 at 16:08,  <mnissler@chromium.org> wrote:
>> > Just a minor request for a clarifying comment.
>> >
>> >
>> >
>> >
http://codereview.chromium.org/5579002/diff/22001/chrome/browser/plugin_data_...
>> > File chrome/browser/plugin_data_remover_helper.cc (right):
>> >
>> >
>> >
http://codereview.chromium.org/5579002/diff/22001/chrome/browser/plugin_data_...
>> > chrome/browser/plugin_data_remover_helper.cc:15: class
>> > PluginDataRemoverHelper::Internal
>> > Could use a class comment saying that it's RefCountedThreadSafe so it
>> > can outlive the remover object?
>>
>> Done.
>>
>> > http://codereview.chromium.org/5579002/
>> >
>
>

[jam, 2010-12-13 22:44:20]

lgtm