Issue 5578007: linux: remove --as-needed in the shared build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5578007: linux: remove --as-needed in the shared build (Closed)

Created:
10 years ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony, Craig

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

linux: remove --as-needed in the shared build The shared build is a quick hack for quick links; we don't need to optimize the link line and, in fact, doing so breaks the v8 link. (Fix from Craig Schlenter <craig.schlenter@chromium.org>.) BUG=61430 TEST=build chrome with GYP_DEFINES=library=shared_library and BUILDTYPE=Release Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68542

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	build/common.gypi	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages