Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: build/common.gypi

Issue 5578007: linux: remove --as-needed in the shared build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 'variables': { 9 'variables': {
10 # .gyp files or targets should set chromium_code to 1 if they build 10 # .gyp files or targets should set chromium_code to 1 if they build
(...skipping 1118 matching lines...) Expand 10 before | Expand all | Expand 10 after
1129 ['library=="shared_library"', { 1129 ['library=="shared_library"', {
1130 # When building with shared libraries, remove the visiblity-hiding 1130 # When building with shared libraries, remove the visiblity-hiding
1131 # flag. 1131 # flag.
1132 'cflags!': [ '-fvisibility=hidden' ], 1132 'cflags!': [ '-fvisibility=hidden' ],
1133 'conditions': [ 1133 'conditions': [
1134 ['target_arch=="x64" or target_arch=="arm"', { 1134 ['target_arch=="x64" or target_arch=="arm"', {
1135 # Shared libraries need -fPIC on x86-64 and arm 1135 # Shared libraries need -fPIC on x86-64 and arm
1136 'cflags': ['-fPIC'] 1136 'cflags': ['-fPIC']
1137 }] 1137 }]
1138 ], 1138 ],
1139 'ldflags!': [
1140 # --as-needed confuses library interdependencies.
1141 # See http://code.google.com/p/chromium/issues/detail?id=61430
1142 '-Wl,--as-needed',
1143 ],
1139 }], 1144 }],
1140 ['linux_use_heapchecker==1', { 1145 ['linux_use_heapchecker==1', {
1141 'variables': {'linux_use_tcmalloc%': 1}, 1146 'variables': {'linux_use_tcmalloc%': 1},
1142 }], 1147 }],
1143 ['linux_use_tcmalloc==0', { 1148 ['linux_use_tcmalloc==0', {
1144 'defines': ['NO_TCMALLOC'], 1149 'defines': ['NO_TCMALLOC'],
1145 }], 1150 }],
1146 ['linux_use_heapchecker==0', { 1151 ['linux_use_heapchecker==0', {
1147 'defines': ['NO_HEAPCHECKER'], 1152 'defines': ['NO_HEAPCHECKER'],
1148 }], 1153 }],
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
1465 # and therefore SYMROOT, needs to be set at the project level. 1470 # and therefore SYMROOT, needs to be set at the project level.
1466 'SYMROOT': '<(DEPTH)/xcodebuild', 1471 'SYMROOT': '<(DEPTH)/xcodebuild',
1467 }, 1472 },
1468 } 1473 }
1469 1474
1470 # Local Variables: 1475 # Local Variables:
1471 # tab-width:2 1476 # tab-width:2
1472 # indent-tabs-mode:nil 1477 # indent-tabs-mode:nil
1473 # End: 1478 # End:
1474 # vim: set expandtab tabstop=2 shiftwidth=2: 1479 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698