Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: chrome/browser/ui/cocoa/nsmenuitem_additions.mm

Issue 5576002: Fix BrowserKeyEventsTest.ReservedAccelerators on Mac 10.6 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update comment. Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/nsmenuitem_additions.mm
diff --git a/chrome/browser/ui/cocoa/nsmenuitem_additions.mm b/chrome/browser/ui/cocoa/nsmenuitem_additions.mm
index 90bb35347239b7febabbe26b728d5d2042583303..1d0420b306c84d0455eddbe63b77edaf09dbf166 100644
--- a/chrome/browser/ui/cocoa/nsmenuitem_additions.mm
+++ b/chrome/browser/ui/cocoa/nsmenuitem_additions.mm
@@ -12,9 +12,6 @@
- (BOOL)cr_firesForKeyEvent:(NSEvent*)event {
Nico 2010/12/04 20:25:15 You can then implement this function as … { if
James Su 2010/12/06 18:37:28 Done.
DCHECK([event type] == NSKeyDown);
- if (![self isEnabled])
- return NO;
-
// In System Preferences->Keyboard->Keyboard Shortcuts, it is possible to add
// arbitrary keyboard shortcuts to applications. It is not documented how this
// works in detail, but |NSMenuItem| has a method |userKeyEquivalent| that

Powered by Google App Engine
This is Rietveld 408576698