Fix BrowserKeyEventsTest.ReservedAccelerators on Mac 10.6

chrome/browser/ui/cocoa/nsmenuitem_additions.h

Index: chrome/browser/ui/cocoa/nsmenuitem_additions.h
diff --git a/chrome/browser/ui/cocoa/nsmenuitem_additions.h b/chrome/browser/ui/cocoa/nsmenuitem_additions.h
index 830498ae9fd86c00fb0b91ac4c4af4d5dca399f9..32170d97f7e5cc08300d6bbd217a7ab89888e719 100644
--- a/chrome/browser/ui/cocoa/nsmenuitem_additions.h
+++ b/chrome/browser/ui/cocoa/nsmenuitem_additions.h
@@ -12,6 +12,11 @@
 
 // Returns true exactly if the menu item would fire if it would be put into
 // a menu and then |menu performKeyEquivalent:event| was called.
+// This method matches the key equivalent regardless of the item's enable state,
+// because this method is only for looking up the corresponding menu item of a
+// specified key equivalent, and even if the item is disabled when calling this
+// method, it might be already enbled when the key equivalent gets handled by
+// NSApp.
 - (BOOL)cr_firesForKeyEvent:(NSEvent*)event;

[Nico, 2010/12/04 20:25:15]

Can you leave the function as is and instead add a new function
cr_firesForKeyEventIfEnabled: that has the new semantics?

[James Su, 2010/12/06 18:37:28]

Done.

 
 @end