chrome/browser/ui/cocoa/nsmenuitem_additions.h - Issue 5576002: Fix BrowserKeyEventsTest.ReservedAccelerators on Mac 10.6

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/nsmenuitem_additions.h

Issue 5576002: Fix BrowserKeyEventsTest.ReservedAccelerators on Mac 10.6 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update comment. Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/browser_keyevents_browsertest.cc ('k') | chrome/browser/ui/cocoa/nsmenuitem_additions.mm » ('j') | chrome/browser/ui/cocoa/nsmenuitem_additions.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_COCOA_NSMENUITEM_ADDITIONS_H_	5 #ifndef CHROME_BROWSER_UI_COCOA_NSMENUITEM_ADDITIONS_H_

6 #define CHROME_BROWSER_UI_COCOA_NSMENUITEM_ADDITIONS_H_	6 #define CHROME_BROWSER_UI_COCOA_NSMENUITEM_ADDITIONS_H_

7 #pragma once	7 #pragma once

8	8

9 #import <Cocoa/Cocoa.h>	9 #import <Cocoa/Cocoa.h>

10	10

11 @interface NSMenuItem(ChromeAdditions)	11 @interface NSMenuItem(ChromeAdditions)

12	12

13 // Returns true exactly if the menu item would fire if it would be put into	13 // Returns true exactly if the menu item would fire if it would be put into

14 // a menu and then \|menu performKeyEquivalent:event\| was called.	14 // a menu and then \|menu performKeyEquivalent:event\| was called.

	15 // This method matches the key equivalent regardless of the item's enable state,

	16 // because this method is only for looking up the corresponding menu item of a

	17 // specified key equivalent, and even if the item is disabled when calling this

	18 // method, it might be already enbled when the key equivalent gets handled by

	19 // NSApp.

15 - (BOOL)cr_firesForKeyEvent:(NSEvent*)event;	20 - (BOOL)cr_firesForKeyEvent:(NSEvent*)event;
	Nico 2010/12/04 20:25:15 Can you leave the function as is and instead add a Can you leave the function as is and instead add a new function cr_firesForKeyEventIfEnabled: that has the new semantics? James Su 2010/12/06 18:37:28 Done. Show quoted text On 2010/12/04 20:25:15, Nico wrote: > Can you leave the function as is and instead add a new function > cr_firesForKeyEventIfEnabled: that has the new semantics? Done.
16	21

17 @end	22 @end

18	23

19 #endif // CHROME_BROWSER_UI_COCOA_NSMENUITEM_ADDITIONS_H_	24 #endif // CHROME_BROWSER_UI_COCOA_NSMENUITEM_ADDITIONS_H_

OLD	NEW