chrome/browser/ui/cocoa/nsmenuitem_additions.mm - Issue 5576002: Fix BrowserKeyEventsTest.ReservedAccelerators on Mac 10.6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/nsmenuitem_additions.mm

Issue 5576002: Fix BrowserKeyEventsTest.ReservedAccelerators on Mac 10.6 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix unittest and remove FLAKY tag. Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/nsmenuitem_additions.mm

diff --git a/chrome/browser/ui/cocoa/nsmenuitem_additions.mm b/chrome/browser/ui/cocoa/nsmenuitem_additions.mm

index 90bb35347239b7febabbe26b728d5d2042583303..1d0420b306c84d0455eddbe63b77edaf09dbf166 100644

--- a/chrome/browser/ui/cocoa/nsmenuitem_additions.mm

+++ b/chrome/browser/ui/cocoa/nsmenuitem_additions.mm

@@ -12,9 +12,6 @@

- (BOOL)cr_firesForKeyEvent:(NSEvent*)event {

DCHECK([event type] == NSKeyDown);

- if (![self isEnabled])

- return NO;

// In System Preferences->Keyboard->Keyboard Shortcuts, it is possible to add

// arbitrary keyboard shortcuts to applications. It is not documented how this

// works in detail, but |NSMenuItem| has a method |userKeyEquivalent| that