chrome/browser/ui/cocoa/nsmenuitem_additions.h - Issue 5576002: Fix BrowserKeyEventsTest.ReservedAccelerators on Mac 10.6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/nsmenuitem_additions.h

Issue 5576002: Fix BrowserKeyEventsTest.ReservedAccelerators on Mac 10.6 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix unittest and remove FLAKY tag. Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/nsmenuitem_additions.h

diff --git a/chrome/browser/ui/cocoa/nsmenuitem_additions.h b/chrome/browser/ui/cocoa/nsmenuitem_additions.h

index 830498ae9fd86c00fb0b91ac4c4af4d5dca399f9..32170d97f7e5cc08300d6bbd217a7ab89888e719 100644

--- a/chrome/browser/ui/cocoa/nsmenuitem_additions.h

+++ b/chrome/browser/ui/cocoa/nsmenuitem_additions.h

@@ -12,6 +12,11 @@

// Returns true exactly if the menu item would fire if it would be put into

// a menu and then |menu performKeyEquivalent:event| was called.

+// This method matches the key equivalent regardless of the item's enable state,

+// because this method is only for looking up the corresponding menu item of a

+// specified key equivalent, and even if the item is disabled when calling this

+// method, it might be already enbled when the key equivalent gets handled by

+// NSApp.

- (BOOL)cr_firesForKeyEvent:(NSEvent*)event;

@end