Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: chrome/test/webdriver/commands/create_session.cc

Issue 5572001: Send screenshots back to the client for debugging (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: added tests which compare against a reference md5 hash Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/commands/create_session.cc
diff --git a/chrome/test/webdriver/commands/create_session.cc b/chrome/test/webdriver/commands/create_session.cc
index b23158e02b18cc88c7d60e395ef09dbd92a235b7..bb80a1bfb905a40280a6ca57b74320804b93c7dc 100644
--- a/chrome/test/webdriver/commands/create_session.cc
+++ b/chrome/test/webdriver/commands/create_session.cc
@@ -37,6 +37,12 @@ void CreateSession::ExecutePost(Response* const response) {
return;
}
+ bool screenshot_on_error;
kkania 2011/03/17 18:35:11 default to false
Joe 2011/03/18 00:33:32 Done.
+ DictionaryValue* capabilities = NULL;
+ if (GetDictionaryParameter("desiredCapabilities", &capabilities)) {
+ capabilities->GetBoolean("takeScreenshotOnError", &screenshot_on_error);
+ }
kkania 2011/03/17 18:35:11 I didn't mean for you to delete the part of sessio
Joe 2011/03/18 00:33:32 Sorry I mistook the comment as to remove the abili
+
VLOG(1) << "Created session " << session->id();
std::ostringstream stream;
stream << "http://" << session_manager->GetAddress() << "/session/"

Powered by Google App Engine
This is Rietveld 408576698