Send screenshots back to the client for debugging

chrome/test/webdriver/commands/create_session.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/webdriver/commands/create_session.h"
 
 #include <sstream>
 #include <string>
 
 #include "base/file_path.h"
@@ skipping 19 matching lines @@
 
   // Session manages its own liftime, so do not call delete.
   Session* session = new Session();
   if (!session->Init(session_manager->chrome_dir())) {
     SET_WEBDRIVER_ERROR(response,
                         "Failed to initialize session",
                         kInternalServerError);
     return;
   }
 
+  bool screenshot_on_error;

[kkania, 2011/03/17 18:35:11]

default to false

[Joe, 2011/03/18 00:33:32]

Done.

+  DictionaryValue* capabilities = NULL;
+  if (GetDictionaryParameter("desiredCapabilities", &capabilities)) {
+    capabilities->GetBoolean("takeScreenshotOnError", &screenshot_on_error);
+  }

[kkania, 2011/03/17 18:35:11]

I didn't mean for you to delete the part of
session->set_screenshot_on_error(screenshot_on_error). Otherwise this doesn't do
anything.

[Joe, 2011/03/18 00:33:32]

Sorry I mistook the comment as to remove the ability for now.
On 2011/03/17 18:35:11, kkania wrote:
Done.

+
   VLOG(1) << "Created session " << session->id();
   std::ostringstream stream;
   stream << "http://" << session_manager->GetAddress() << "/session/"
          << session->id();
   response->SetStatus(kSeeOther);
   response->SetValue(Value::CreateStringValue(stream.str()));
 }
 
 }  // namespace webdriver