Issue 557087: Fixed compile error for unit-tests on linux. We do not include any glew file ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 557087: Fixed compile error for unit-tests on linux. We do not include any glew file ... (Closed)

Created:
10 years, 10 months ago by alokp

Modified:
9 years, 6 months ago

Reviewers:
gman1, greggman, piman

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixed compile error for unit-tests on linux. We do not include any glew file for unitests. They are mocked in gl_mock.h. gles2_cmd_decoder.cc included x_utils.h which in turn included glxew.h. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37834

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
M	gpu/command_buffer/service/gl_utils.h	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/x_utils.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

alokp

Never mind. Now I see the usage of XWindowWrapper. I will redo this.

10 years, 10 months ago (2010-02-01 20:55:26 UTC) #3

greggman

http://codereview.chromium.org/557087/diff/1/2 File gpu/command_buffer/service/gles2_cmd_decoder.cc (left): http://codereview.chromium.org/557087/diff/1/2#oldcode20 gpu/command_buffer/service/gles2_cmd_decoder.cc:20: #if defined(OS_LINUX) If this works great but I suspect ...

10 years, 10 months ago (2010-02-01 20:58:04 UTC) #4

alokp

This version works and also passes try bots. Please review.

10 years, 10 months ago (2010-02-01 21:47:26 UTC) #5

LGTM

Expand Messages | Collapse Messages