Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 557026: Disables pinned tabs until I land apps. I've #ifdef parts that are... (Closed)

Created:
10 years, 11 months ago by sky
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Disables pinned tabs until I land apps. I've #ifdef parts that are going to stay around, but need to be disabled for now. BUG=32845 TEST=make sure pinned tabs are disabled for now. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37421

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -38 lines) Patch
M chrome/browser/browser_init.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 3 chunks +4 lines, -22 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/sessions/tab_restore_service_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/tab_menu_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_menu_model.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sky
10 years, 11 months ago (2010-01-28 00:28:17 UTC) #1
Ben Goodger (Google)
OK
10 years, 11 months ago (2010-01-28 07:03:44 UTC) #2
Andreas C
On 2010/01/28 07:03:44, Ben Goodger wrote: > OK Is there any ETA on when we ...
10 years, 10 months ago (2010-02-26 11:05:45 UTC) #3
sky
It's enabled on tip of tree for windows. The linux and mac sides should be ...
10 years, 10 months ago (2010-02-26 17:28:57 UTC) #4
Andreas C
Soon as in? 4 weeks has already passed. On 2010/02/26 17:28:57, sky wrote: > It's ...
10 years, 9 months ago (2010-03-27 13:17:59 UTC) #5
sky
Indeed. Pinned tabs are enabled on all platforms now. -Scott On Sat, Mar 27, 2010 ...
10 years, 9 months ago (2010-03-28 23:08:51 UTC) #6
Garrett.Gregor
I'm 5.0.342.7 beta up to date... Could my plugins be mucking up the ability to ...
10 years, 8 months ago (2010-04-04 20:49:04 UTC) #7
Use pkasting(at)chromium.org
10 years, 8 months ago (2010-04-04 21:11:19 UTC) #8
On Sun, Apr 4, 2010 at 1:49 PM, <Garrett.Gregor@gmail.com> wrote:

> I'm 5.0.342.7 beta up to date...
>
> Could my plugins be mucking up the ability to pin tabs? Or is there some
> alpha
> version or some other beta I'm missing?


I suspect it's that you're on Beta, rather than Dev.  Dev is at build 366.

PK

Powered by Google App Engine
This is Rietveld 408576698