Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 5567001: Remove IDS_ABOUT_PAGE_TITLE and use IDS_ABOUT instead. (Closed)

Created:
10 years ago by kochi
Modified:
9 years, 7 months ago
Reviewers:
alcor, Evan Stade
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Remove IDS_ABOUT_PAGE_TITLE and use IDS_ABOUT instead. The description for IDS_ABOUT_PAGE_TITLE (Title used for about options panel) was ambiguous enough to confuse translators: 1. Title used for <about> <options panel> (original intention) 2. Title used for <about options> panel (misunderstanding) And unfortunately for Japanese, 2 was translated. 2 ways to fix this, clarify the description or use IDS_ABOUT. As title on the wrench menu use IDS_ABOUT ("About &PRODUCT_NAME"), using IDS_ABOUT for the title for the options panel makes sense. BUG=none TEST=manually open chrome://settings/about (or wrench menu -> about) and see tht title displayed properly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68336

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/options/about_page_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
kochi
Hi Evan, (+alcor for the original design) As you are one of the reviewers in ...
10 years ago (2010-12-02 05:58:16 UTC) #1
Evan Stade
10 years ago (2010-12-02 19:51:53 UTC) #2
removing a surplus string LGTM

Powered by Google App Engine
This is Rietveld 408576698