Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Side by Side Diff: chrome/browser/dom_ui/options/about_page_handler.cc

Issue 5567001: Remove IDS_ABOUT_PAGE_TITLE and use IDS_ABOUT instead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/dom_ui/options/about_page_handler.h" 5 #include "chrome/browser/dom_ui/options/about_page_handler.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "app/resource_bundle.h" 8 #include "app/resource_bundle.h"
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 { "copyright", IDS_ABOUT_VERSION_COPYRIGHT }, 79 { "copyright", IDS_ABOUT_VERSION_COPYRIGHT },
80 { "channel", IDS_ABOUT_PAGE_CHANNEL }, 80 { "channel", IDS_ABOUT_PAGE_CHANNEL },
81 { "release", IDS_ABOUT_PAGE_CHANNEL_RELEASE }, 81 { "release", IDS_ABOUT_PAGE_CHANNEL_RELEASE },
82 { "beta", IDS_ABOUT_PAGE_CHANNEL_BETA }, 82 { "beta", IDS_ABOUT_PAGE_CHANNEL_BETA },
83 { "development", IDS_ABOUT_PAGE_CHANNEL_DEVELOPMENT }, 83 { "development", IDS_ABOUT_PAGE_CHANNEL_DEVELOPMENT },
84 { "canary", IDS_ABOUT_PAGE_CHANNEL_CANARY }, 84 { "canary", IDS_ABOUT_PAGE_CHANNEL_CANARY },
85 { "channel_warning_header", IDS_ABOUT_PAGE_CHANNEL_WARNING_HEADER }, 85 { "channel_warning_header", IDS_ABOUT_PAGE_CHANNEL_WARNING_HEADER },
86 { "channel_warning_text", IDS_ABOUT_PAGE_CHANNEL_WARNING_TEXT }, 86 { "channel_warning_text", IDS_ABOUT_PAGE_CHANNEL_WARNING_TEXT },
87 { "user_agent", IDS_ABOUT_VERSION_USER_AGENT }, 87 { "user_agent", IDS_ABOUT_VERSION_USER_AGENT },
88 { "command_line", IDS_ABOUT_VERSION_COMMAND_LINE }, 88 { "command_line", IDS_ABOUT_VERSION_COMMAND_LINE },
89 { "aboutPage", IDS_ABOUT_PAGE_TITLE } 89 { "aboutPage", IDS_ABOUT }
90 }; 90 };
91 91
92 void LocalizedStrings(DictionaryValue* localized_strings) { 92 void LocalizedStrings(DictionaryValue* localized_strings) {
93 for (size_t n = 0; n != arraysize(localize_table); ++n) { 93 for (size_t n = 0; n != arraysize(localize_table); ++n) {
94 localized_strings->SetString(localize_table[n].identifier, 94 localized_strings->SetString(localize_table[n].identifier,
95 l10n_util::GetStringUTF16(localize_table[n].resource)); 95 l10n_util::GetStringUTF16(localize_table[n].resource));
96 } 96 }
97 } 97 }
98 98
99 } // namespace 99 } // namespace
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
392 392
393 void AboutPageHandler::OnOSVersion(chromeos::VersionLoader::Handle handle, 393 void AboutPageHandler::OnOSVersion(chromeos::VersionLoader::Handle handle,
394 std::string version) { 394 std::string version) {
395 if (version.size()) { 395 if (version.size()) {
396 scoped_ptr<Value> version_string(Value::CreateStringValue(version)); 396 scoped_ptr<Value> version_string(Value::CreateStringValue(version));
397 dom_ui_->CallJavascriptFunction(L"AboutPage.updateOSVersionCallback", 397 dom_ui_->CallJavascriptFunction(L"AboutPage.updateOSVersionCallback",
398 *version_string); 398 *version_string);
399 } 399 }
400 } 400 }
401 #endif 401 #endif
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698