A scoped NetLog event that automatically logs an end event on destruction.

A ScopedNetLogEvent that logs a NetLog begin event on creation,
and the corresponding end event on destruction.

BUG=64981
TEST=NetLog.ScopedNetLogEventTest


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68742

[mmenke, 2010-12-08 20:53:55]

Might be convenient to have this inherit from BoundNetLog instead, so classes
that log an event on destruction could use it instead of a standard BoundNetLog,
but then using the same type of object just to log other events would strike me
as a little funky.

That having been said, as its BoundNetLog is publicly accessible, can
theoretically do that with this implementation, too.

[eroman, 2010-12-09 02:00:14]

lgtm

http://codereview.chromium.org/5560013/diff/14001/net/base/net_log.cc
File net/base/net_log.cc (right):

http://codereview.chromium.org/5560013/diff/14001/net/base/net_log.cc#newcode203
net/base/net_log.cc:203: end_event_parameters_(NULL) {
nit: I have always seen this omitted in chrome code, and rely on default
constructor.

http://codereview.chromium.org/5560013/diff/14001/net/base/net_log_unittest.cc
File net/base/net_log_unittest.cc (right):

http://codereview.chromium.org/5560013/diff/14001/net/base/net_log_unittest.c...
net/base/net_log_unittest.cc:11: net::CapturingNetLog
log(net::CapturingNetLog::kUnbounded);
nit: I generally like to put my unit tests inside of:

namespace net {
namespace {

<<--->>

}
}

to avoid prefixing everything with net::

[mmenke, 2010-12-09 15:12:01]

Thanks.

http://codereview.chromium.org/5560013/diff/14001/net/base/net_log.cc
File net/base/net_log.cc (right):

http://codereview.chromium.org/5560013/diff/14001/net/base/net_log.cc#newcode203
net/base/net_log.cc:203: end_event_parameters_(NULL) {
On 2010/12/09 02:00:14, eroman wrote:
> nit: I have always seen this omitted in chrome code, and rely on default
> constructor.

Done.

http://codereview.chromium.org/5560013/diff/14001/net/base/net_log_unittest.cc
File net/base/net_log_unittest.cc (right):

http://codereview.chromium.org/5560013/diff/14001/net/base/net_log_unittest.c...
net/base/net_log_unittest.cc:11: net::CapturingNetLog
log(net::CapturingNetLog::kUnbounded);
On 2010/12/09 02:00:14, eroman wrote:
> nit: I generally like to put my unit tests inside of:
> 
> namespace net {
> namespace {
> 
> <<--->>
> 
> }
> }
> 
> to avoid prefixing everything with net::

Both namespaces added.  Does make for cleaner code.  Looks the majority of unit
tests don't use an anonymous namespace.