Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Side by Side Diff: net/base/net_log_unittest.cc

Issue 5560013: A scoped NetLog event that automatically logs an end event on destruction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
Property Changes:
Added: svn:eol-style
+ LF
OLDNEW
(Empty)
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "net/base/capturing_net_log.h"
6 #include "net/base/net_log.h"
7 #include "net/base/net_log_unittest.h"
8 #include "testing/gtest/include/gtest/gtest.h"
9
10 TEST(NetLog, ScopedNetLogEventTest) {
11 net::CapturingNetLog log(net::CapturingNetLog::kUnbounded);
eroman 2010/12/09 02:00:14 nit: I generally like to put my unit tests inside
mmenke 2010/12/09 15:12:01 Both namespaces added. Does make for cleaner code
12 net::BoundNetLog net_log(
13 net::BoundNetLog::Make(&log, net::NetLog::SOURCE_URL_REQUEST));
14
15 scoped_ptr<net::ScopedNetLogEvent> net_log_event(
16 new net::ScopedNetLogEvent(net_log, net::NetLog::TYPE_REQUEST_ALIVE,
17 NULL));
18
19 net::CapturingNetLog::EntryList entries;
20 log.GetEntries(&entries);
21 EXPECT_EQ(1u, entries.size());
22 EXPECT_TRUE(net::LogContainsBeginEvent(
23 entries, 0, net::NetLog::TYPE_REQUEST_ALIVE));
24
25 net_log_event.reset();
26 log.GetEntries(&entries);
27 EXPECT_EQ(2u, entries.size());
28 EXPECT_TRUE(net::LogContainsEndEvent(
29 entries, 1, net::NetLog::TYPE_REQUEST_ALIVE));
30 }
OLDNEW
« net/base/net_log.cc ('K') | « net/base/net_log.cc ('k') | net/net.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698