Don't update icon of chrome app shortcuts from the favicon of the hosted URL.

chrome/browser/ui/browser.h

Index: chrome/browser/ui/browser.h
diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
index 77c21460cb644307709c20db35619d15d6a99a77..d7da75d329f6c5d96e3d7a8d28f4ea0304df2c4f 100644
--- a/chrome/browser/ui/browser.h
+++ b/chrome/browser/ui/browser.h
@@ -245,15 +245,21 @@ class Browser : public TabHandlerDelegate,
   // app panel window, otherwise it will be opened as as either
   // Browser::Type::APP a.k.a. "thin frame" (if |extension| is NULL) or
   // Browser::Type::EXTENSION_APP (if |extension| is non-NULL).
+  // If |app_browser| is not NULL, it is set to the browser that hosts the
+  // returned tab.
   static TabContents* OpenApplicationWindow(
       Profile* profile,
       const Extension* extension,
       extension_misc::LaunchContainer container,
-      const GURL& url);
-
-  // Open an application in a new application window.  Used to implement
-  // app shortcuts.
-  static TabContents* OpenApplicationWindow(Profile* profile, const GURL& url);
+      const GURL& url,
+      Browser** app_browser);
+
+  // Open a window hosting a URL.  Used to implement url app shortcuts.

[Aaron Boodman, 2010/12/06 23:45:24]

Don't all windows host URLs? Maybe "Open a URL in an app shortcut window".

[Sam Kerner (Chrome), 2010/12/07 04:12:30]

Done.

+  // If |update_shortcut| is true, update the name, description, and
+  // favicon of the shortcut.
+  static TabContents* OpenUrlAppShortcutWindow(Profile* profile,

[Aaron Boodman, 2010/12/06 23:45:24]

Good terminology change 'app -> appshortcut', but whatabout
OpenAppShortcutWindow instead?

[Sam Kerner (Chrome), 2010/12/07 04:12:30]

Done.

+                                               const GURL& url,
+                                               bool update_shortcut);
 
   // Open an application for |extension| in a new application tab, or
   // |existing_tab| if not NULL.  Returns NULL if there are no appropriate