Issue 5560001: Revert 67949 - [gtk] tab in omnibox...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5560001: Revert 67949 - [gtk] tab in omnibox... (Closed)

Created:
10 years ago by rohitrao (ping after 24h)

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 67949 - [gtk] tab in omnibox BUG=64340 TEST=see bug Review URL: http://codereview.chromium.org/5339014 TBR=estade@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67955

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -44 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_edit.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc	View	2 chunks	+16 lines, -30 lines	0 comments	Download
M	chrome/browser/gtk/location_bar_view_gtk.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/location_bar_view_gtk.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

10 years ago (2010-12-02 03:23:59 UTC) #2

This CL caused BrowserFocusTest.FocusTraversal and
BrowserFocusTest.FocusTraversalOnInterstitial to fail on the chromeos
bots.

http://build.chromium.org/p/chromium/builders/Linux%20Builder%20(ChromiumOS)/...

http://build.chromium.org/p/chromium/builders/Linux%20Builder%20(Views%20dbg)...

- Rohit

On Wed, Dec 1, 2010 at 10:21 PM,  <rohitrao@chromium.org> wrote:
> Reviewers: Evan Stade,
>
> Description:
> Revert 67949 - [gtk] tab in omnibox
>
> BUG=64340
> TEST=see bug
>
> Review URL: http://codereview.chromium.org/5339014
>
> TBR=estade@chromium.org
>
> Please review this at http://codereview.chromium.org/5560001/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/autocomplete/autocomplete_edit.h
>  M     chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc
>  M     chrome/browser/gtk/location_bar_view_gtk.h
>  M     chrome/browser/gtk/location_bar_view_gtk.cc
>
>
>

Expand Messages | Collapse Messages