Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5339014: [gtk] tab in omnibox (Closed)

Created:
10 years ago by Evan Stade
Modified:
5 years, 6 months ago
Reviewers:
James Su, sky
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

[gtk] tab in omnibox BUG=64340 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67949

Patch Set 1 #

Patch Set 2 : better comment #

Total comments: 2

Patch Set 3 : don't break focus switch #

Patch Set 4 : don't randomly add a newline #

Total comments: 2

Patch Set 5 : comment retval #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -16 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 1 2 3 2 chunks +30 lines, -16 lines 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/gtk/location_bar_view_gtk.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Evan Stade
10 years ago (2010-12-01 02:11:07 UTC) #1
James Su
http://codereview.chromium.org/5339014/diff/2001/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right): http://codereview.chromium.org/5339014/diff/2001/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc#newcode1408 chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc:1408: handled = true; Should handled always be set to ...
10 years ago (2010-12-01 02:18:33 UTC) #2
Evan Stade
http://codereview.chromium.org/5339014/diff/2001/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right): http://codereview.chromium.org/5339014/diff/2001/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc#newcode1408 chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc:1408: handled = true; On 2010/12/01 02:18:33, James Su wrote: ...
10 years ago (2010-12-01 04:00:58 UTC) #3
James Su
LGTM.
10 years ago (2010-12-01 04:26:01 UTC) #4
sky
http://codereview.chromium.org/5339014/diff/10001/chrome/browser/autocomplete/autocomplete_edit.h File chrome/browser/autocomplete/autocomplete_edit.h (right): http://codereview.chromium.org/5339014/diff/10001/chrome/browser/autocomplete/autocomplete_edit.h#newcode53 chrome/browser/autocomplete/autocomplete_edit.h:53: // Accepts the currently showing instant preview, if any. ...
10 years ago (2010-12-01 15:53:16 UTC) #5
Evan Stade
http://codereview.chromium.org/5339014/diff/10001/chrome/browser/autocomplete/autocomplete_edit.h File chrome/browser/autocomplete/autocomplete_edit.h (right): http://codereview.chromium.org/5339014/diff/10001/chrome/browser/autocomplete/autocomplete_edit.h#newcode53 chrome/browser/autocomplete/autocomplete_edit.h:53: // Accepts the currently showing instant preview, if any. ...
10 years ago (2010-12-01 18:37:25 UTC) #6
sky
10 years ago (2010-12-01 18:42:44 UTC) #7 
Ok, LGTM

Powered by Google App Engine
This is Rietveld 408576698